Skip to content

New Crowdin updates #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 9, 2024
Merged

New Crowdin updates #799

merged 17 commits into from
Dec 9, 2024

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Dec 8, 2024

No description provided.

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit e4acc20
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/6755f4e4cfcfd400088ceda4
😎 Deploy Preview https://deploy-preview-799--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InessaPawson InessaPawson merged commit 960228a into main Dec 9, 2024
4 checks passed
@InessaPawson InessaPawson deleted the l10n_main branch December 9, 2024 01:41
@InessaPawson
Copy link
Member

Thank you, @rgommers!

@rgommers
Copy link
Member Author

rgommers commented Dec 9, 2024

This looks a little off. I may have set up some integration, but I did not open this PR so it shouldn't look like it comes from me. A previous one had a bot handle: gh-793.

@steppi any idea what happened here?

@InessaPawson InessaPawson mentioned this pull request Dec 12, 2024
@steppi
Copy link
Contributor

steppi commented Dec 13, 2024

My apologies @InessaPawson and @rgommers. This PR should not have been merged and it's entirely my fault. It was generated by Crowdin and has commits for all updates made by translators within the Crowdin UI. @rgommers set up the integration, so he appears as the author. The bot handle for gh-793 is a red herring, that PR was generated by one of our GitHub workflows, and takes commits from the Crowdin PR branch l10n_main for only one particular language, puts them in a new branch and PRs that branch. As far as I know, the only way to make the author of the Crowdin PR to appear as a bot would be to create a "bot" account with admin privileges on this repo and use it to set up the Crowdin integration.

On translations repos for other projects I added a do-not-merge label and a CI job that fails if the do-not-merge label is presents, with merging disallowed if the job fails. See Scientific-Python-Translations/pandas-translations#56. I guess because translations for this repo aren't managed in the scientific-python-translations organization, I forgot to set up the do-not-merge thing here. I'll do that, and also look into reverting these changes.

@rgommers
Copy link
Member Author

Thanks for the context @steppi. That sounds like a good plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants