Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in numpy.insert() when axis != None #392

Closed
vizowl opened this issue Aug 27, 2012 · 1 comment
Closed

Regression in numpy.insert() when axis != None #392

vizowl opened this issue Aug 27, 2012 · 1 comment
Milestone
NumPy 1.7

Comments

@vizowl
Copy link

vizowl commented Aug 27, 2012

I believe that the fix to Ticket #808 has caused a regression in numpy.insert()

This is the commit

Previously:

np.insert([[1,1,1]], 0, [2,2,2], axis=0)

gave:

 array([[2, 2, 2],
      [1, 1, 1]])

now it gives

array([[2, 2, 2],
   [2, 2, 2],
   [2, 2, 2],
   [1, 1, 1]])

I don't think is the correct result.

Also issue #378 is a result of same change
@njsmith njsmith mentioned this issue Aug 31, 2012
Closed
87 added a commit to 87/numpy that referenced this issue Sep 7, 2012
@87
BUG: Fix for issues numpy#378 and numpy#392
926564c 
This should fix the problems with numpy.insert(), where the input values
were not checked for all scalar types and where values did not get inserted
properly, but got duplicated by default.
@87 87 mentioned this issue Sep 7, 2012
Merged
njsmith added a commit that referenced this issue Sep 11, 2012
@njsmith
Merge pull request #429 from 87/fix_insert
aed8fc5 
Fix for issues #392 and #378
certik pushed a commit to certik/numpy that referenced this issue Sep 13, 2012
@87 @certik
BUG: Fix for issues numpy#378 and numpy#392
8460514 
This should fix the problems with numpy.insert(), where the input values
were not checked for all scalar types and where values did not get inserted
properly, but got duplicated by default.
@certik
Copy link
Contributor

certik commented Nov 14, 2012

I think this is now fixed.

@certik certik closed this as completed Nov 14, 2012
@vizowl vizowl mentioned this issue Aug 27, 2012
Closed
luyahan pushed a commit to plctlab/numpy that referenced this issue Apr 25, 2024
@howjmay
Merge pull request numpy#392 from howjmay/vminv
2900f11 
feat: Add vminv[q]_[s8|s16|s32|u8|u16|u32|f32|f64]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NumPy 1.7
Development

No branches or pull requests
2 participants
@certik @vizowl