MAINT: Fix spelling error in npy_tempita kwarg #14005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the spelling of the ``delimeter`` kwarg to ``delimiter`` (note the second e -> i) in the npy_tempita module. This npy_tempita vendorises Tempita a minimal templating language. The spelling has been fixed in the official documentation [1] and source code [2]. This commit fixes that fix by aligning npy_tempita with the reference documentation. Although the vendored version is used in NumPy the delimeter kwarg is not. This raised the consideration of reverting to either the original version or Cython's non-vendored version [3]. Both were decided against because: 1. The original is not actively maintained and required some fixes. 2. Cython's Tempita is an internal Cython tool and Cython may not guarantee that it will be present. [1] https://pyrocore.readthedocs.io/en/latest/tempita.html [2] https://bitbucket.org/ianb/tempita/src/default/tempita/__init__.py [3] https://github.com/cython/cython/blob/master/Cython/Tempita/_tempita.py
charris
changed the title
eric-wieser
approved these changes
Jul 15, 2019
|
Thanks @Kai-Striega . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the spelling of the
delimeterkwarg todelimiter(note the second e -> i) in the npy_tempita module. Thisnpy_tempita vendorises Tempita a minimal templating language.
The spelling has been fixed in the official documentation [1] and source
code [2]. This commit fixes that fix by aligning npy_tempita with the
reference documentation.
Although the vendored version is used in NumPy the delimeter kwarg is
not. This raised the consideration of reverting to either the original
version or Cython's non-vendored version [3]. Both were decided against
because:
guarantee that it will be present.
[1] https://pyrocore.readthedocs.io/en/latest/tempita.html
[2] https://bitbucket.org/ianb/tempita/src/default/tempita/__init__.py
[3] https://github.com/cython/cython/blob/master/Cython/Tempita/_tempita.py