Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Check for existence of fromstr which used in fromstr_next_element #14174

Merged
merged 1 commit into from
Aug 2, 2019
Merged

BUG: Check for existence of fromstr which used in fromstr_next_element #14174

merged 1 commit into from
Aug 2, 2019

Conversation

zjpoh
Copy link
Member

@zjpoh zjpoh commented Aug 1, 2019

Fix #14173.

seberg
seberg approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am willing to put this in without a test, as writing a custom dtype just to test this is going a bit far probably. Should have a BUG tag probably, but I can add that while merging (just waiting a bit).

@seberg seberg changed the title Change scanfunc to fromstr BUG: Check for existence of fromstr which used in fromstr_next_element Aug 2, 2019
@seberg seberg merged commit 3d5fee2 into numpy:master Aug 2, 2019
@zjpoh zjpoh deleted the scanfunc_fromstr branch August 4, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird dtype->f->(scanfunc|fromstr) inconsistency
2 participants
@zjpoh @seberg