DEP: Finish the out kwarg deprecation for ufunc calls #14710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was started in numpygh-14682 but I missed the path in the override.c (since we parse these things multiple times currently). I am not clear why the test seems to be flaky to be honest...
eric-wieser
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was started in gh-14682 but I missed the path in the override.c
(since we parse these things multiple times currently).
I am not clear why the test seems to be flaky to be honest...
I would blame silencing of warnings for the flaky tests, but that does not really make sense here/anymore... Maybe a pytest thing really, since after the DeprecationWarning, there would still be an error raised.