Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix module name bug in signature files [urgent] [f2py] #25267

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Nov 28, 2023

Closes #25263 by more clearly demarcating the case of -h (signature file generation) and the other cases.

Needs a backport, @charris, since it was introduced in the backported 9140edd.

Co-authored-by: jmrohwer <jmrohwer@users.noreply.github.com>
@HaoZeke HaoZeke changed the title BUG: Fix module name bug in signature files BUG: Fix module name bug in signature files [urgent] [f2py] Nov 28, 2023
@HaoZeke HaoZeke requested a review from mattip November 28, 2023 21:38
@HaoZeke HaoZeke marked this pull request as draft November 28, 2023 21:50
@HaoZeke HaoZeke marked this pull request as ready for review November 28, 2023 21:54
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good go me, thanks @HaoZeke

@charris charris merged commit be0589e into numpy:main Nov 30, 2023
61 checks passed
@charris
Copy link
Member

charris commented Nov 30, 2023

Thanks Rohit.

@HaoZeke HaoZeke deleted the gh25263 branch November 30, 2023 04:06
charris pushed a commit to charris/numpy that referenced this pull request Dec 23, 2023
)

* TST: Add one for numpygh-25263

Co-authored-by: jmrohwer <jmrohwer@users.noreply.github.com>

* BUG: Handle modules correctly for F77

Closes numpygh-25263

---------

Co-authored-by: jmrohwer <jmrohwer@users.noreply.github.com>
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 23, 2023
@HaoZeke HaoZeke restored the gh25263 branch June 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: F2PY: module name not written to signature file (regression)
3 participants