-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix module name bug in signature files [urgent] [f2py] #25267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jmrohwer <jmrohwer@users.noreply.github.com>
HaoZeke
added
00 - Bug
component: numpy.f2py
09 - Backport-Candidate
PRs tagged should be backported
labels
Nov 28, 2023
HaoZeke
changed the title
BUG: Fix module name bug in signature files
BUG: Fix module name bug in signature files [urgent] [f2py]
Nov 28, 2023
melissawm
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good go me, thanks @HaoZeke
Thanks Rohit. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Dec 23, 2023
) * TST: Add one for numpygh-25263 Co-authored-by: jmrohwer <jmrohwer@users.noreply.github.com> * BUG: Handle modules correctly for F77 Closes numpygh-25263 --------- Co-authored-by: jmrohwer <jmrohwer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25263 by more clearly demarcating the case of
-h
(signature file generation) and the other cases.Needs a backport, @charris, since it was introduced in the backported 9140edd.