BUG?: References always have an errant second link

[larsoner]

Why do the references have a link that points nowhere? For example for this:

http://scipy.github.io/devdocs/generated/scipy.signal.windows.dpss.html#id1

Each ref is used once but there are two links, the second of which points to a tag that does not seem to exist.

[jnothman]

Presumably #136 needed more testing. It's not obvious to me what's creating this issue. #134 is possibly also related...

[larsoner]

On master for my minimal example code min.zip it looks like:

[1] | (1, 2) Hyvarinen, A., 1999. Fast and robust fixed-point algorithms for independent component analysis. IEEE transactions on Neural Networks, 10(3), pp.626-634.

I checked out the commit that immediately preceded #136 (21a194e) and it still occurs and looks like:

[R1] | (1, 2) Hyvarinen, A., 1999. Fast and robust fixed-point algorithms for independent component analysis. IEEE transactions on Neural Networks, 10(3), pp.626-634.

So the problem appears to precede your PR.

[jnothman]

thanks for thoroughly debunking my kneejerk guess! I see that you're right. I can fix the bug locally by reverting 0970cdb. firstly this may be deemed a sphinx/docutils bug since the backref is used despite being in a LaTeX only environment. Secondly we only need this hack where a reference is not otherwise cited, but that solution may be a bit hacky.

[larsoner]

Secondly we only need this hack where a reference is not otherwise cited, but that solution may be a bit hacky.

Maybe we should look at what HTML and LaTeX PDFs are produced by this only-add-ref-if-needed solution? It seems like the easier route.

[jnothman]

another way this might work nicely is by hacking the doctree rather than the reST. sorry I only have time to throw out ideas and not to implement atm

[jnothman]

Another option might be to pass builder information into SphinxDocString and only generate this latex-only code if in a latex builder, rather than relying on reST directives.

[jnothman]

The fix in #180 simply removes backreferences where the reference does not exist.