-
-
Notifications
You must be signed in to change notification settings - Fork 169
PEP8 Fixes #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 Fixes #32
Conversation
@@ -500,8 +509,8 @@ def __init__(self, cls, doc=None, modulename='', func_doc=FunctionDoc, | |||
raise ValueError("Expected a class or None, but got %r" % cls) | |||
self._cls = cls | |||
|
|||
self.show_inherited_members = config.get('show_inherited_class_members', | |||
True) | |||
self.show_inherited_members = \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no backslashes please, that's bad style. if this is copied from scikit-learn, it should be changed there. If you wanted to get this line to <80 chars, a better way would be
self.show_inherited_members = config.get(
'show_inherited_class_members', True)
This looks fine except for the one |
@rgommers Have removed the
Thanks! I have referenced your suggestion in a comment... |
Looks good to me now, thanks. I'll leave it open for a bit in case someone else wants to comment. |
Looks fine, but I'm not sure why you're pinging me. I don't have pull rights on this repo. |
OK in it goes. Thanks @ragv |
Thanks for the merge :) |
@larsmans Sorry I had incorrectly assumed you had! Thanks for reviewing it anyway :) |
This is an attempt to sync between numpy's and scikit-learn's version of numpydoc.
Currently I have made numpydoc's version PEP8 compliant to avoid trivial merge conflicts between both versions.
@larsmans Could you take a look at this?