Skip to content

Fix Warnings section in validate #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2021
Merged

Fix Warnings section in validate #335

merged 2 commits into from
Oct 25, 2021

Conversation

MatthewFlamm
Copy link
Contributor

Fixes #334. Added tests.

@larsoner
Copy link
Collaborator

Can you rebase or merge with upstream/main? It should fix CircleCI

@MatthewFlamm MatthewFlamm force-pushed the fix-warnings-validate branch from 65abd22 to 3fbd0d4 Compare October 22, 2021 20:09
@MatthewFlamm
Copy link
Contributor Author

MatthewFlamm commented Oct 22, 2021 •
edited
Loading

Can you rebase or merge with upstream/main? It should fix CircleCI

Rebased on main branch, you'll have to start CI again.

@larsoner larsoner merged commit be70dd9 into numpy:main Oct 25, 2021
@larsoner
Copy link
Collaborator

Thanks @MatthewFlamm !

@jarrodmillman jarrodmillman added this to the 1.2.0 milestone Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: Maintenance
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Warnings is not allowed in "GL06" check
3 participants
@MatthewFlamm @larsoner @jarrodmillman