MAINT inspect.getfullargspec is deprecated in Py3.5 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| argspec = inspect.getargspec(func) | ||
| argspec = inspect.formatargspec(*argspec) | ||
| argspec = argspec.replace('*', '\*') |
There was a problem hiding this comment.
Does inspect.signature deal with this?
There was a problem hiding this comment.
hum, probably not indeed. This is for rst escaping right?
There was a problem hiding this comment.
I amended my commit to fix this and added a check in the tests.
ogrisel
force-pushed
the
python-3.5-getfullargspec-deprecated
branch
from
7f7a6d8 to
b9c4c90
Compare
|
The tests pass including the newly introduced check on the escaping of the star character. |
pv
added a commit
that referenced
this pull request
Oct 25, 2015
MAINT: inspect.getfullargspec is deprecated in Py3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And the code is much nicer with the new signature API.