Skip to content

Conversation

sterrettm2
Copy link
Contributor

@sterrettm2 sterrettm2 commented Apr 22, 2024

This merge request adds tests for the base-case behavior of kv-sort, and fixes the current bug with it causing an infinite loop when it receives an array of size 0 or 1 as input.

r-devulap
r-devulap previously approved these changes Apr 23, 2024
Copy link
Member

@r-devulap r-devulap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-devulap
Copy link
Member

Ah, darn. merge conflicts

@r-devulap r-devulap merged commit aad3db1 into numpy:main Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants