Skip to content

Hide keyvalue_qsort symbols in shared library #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024
Merged

Hide keyvalue_qsort symbols in shared library #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9d207
Do not export keyvalue_qsort symbols
May 7, 2024
d11cc1f
Update release and soversion
May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/x86simdsort-internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace avx512 {
qsort(T *arr, size_t arrsize, bool hasnan = false, bool descending = false);
// key-value quicksort
template <typename T1, typename T2>
XSS_EXPORT_SYMBOL void
XSS_HIDE_SYMBOL void
keyvalue_qsort(T1 *key, T2 *val, size_t arrsize, bool hasnan = false);
// quickselect
template <typename T>
Expand Down Expand Up @@ -46,7 +46,7 @@ namespace avx2 {
qsort(T *arr, size_t arrsize, bool hasnan = false, bool descending = false);
// key-value quicksort
template <typename T1, typename T2>
XSS_EXPORT_SYMBOL void
XSS_HIDE_SYMBOL void
keyvalue_qsort(T1 *key, T2 *val, size_t arrsize, bool hasnan = false);
// quickselect
template <typename T>
Expand Down Expand Up @@ -80,7 +80,7 @@ namespace scalar {
qsort(T *arr, size_t arrsize, bool hasnan = false, bool descending = false);
// key-value quicksort
template <typename T1, typename T2>
XSS_EXPORT_SYMBOL void
XSS_HIDE_SYMBOL void
keyvalue_qsort(T1 *key, T2 *val, size_t arrsize, bool hasnan = false);
// quickselect
template <typename T>
Expand Down
4 changes: 2 additions & 2 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
project('x86-simd-sort', 'cpp',
version : '4.0.0',
version : '5.0.x',
license : 'BSD 3-clause',
default_options : ['cpp_std=c++17'])
fs = import('fs')
Expand Down Expand Up @@ -40,7 +40,7 @@ libsimdsort = shared_library('x86simdsortcpp',
link_with : [libtargets],
gnu_symbol_visibility : 'inlineshidden',
install : true,
soversion : 0,
soversion : 1,
)

pkg_mod = import('pkgconfig')
Expand Down