-
-
Notifications
You must be signed in to change notification settings - Fork 69
Add qsort for _Float16 using AVX-512 FP16 ISA #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r-devulap
commented
Mar 15, 2023
- Add new file avx512fp16-16bit-qsort.hpp
- Add new tests for _Float16 on SPR
- Update meson and Make build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments from the peanut gallery. 😁
If you'd like, I could post a companion PR, if you'd like to see how I'd do the meson coding... but only if you're interested.
@@ -1,16 +1,15 @@ | |||
CXX ?= g++ | |||
CXX = g++-12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'll bite if others don't use the exact same distro and packaging as you. Best not to hard-assign the compiler in a Makefile.
Continue to use ?=
so the end-user can override (with, say, g++-12
) in an env var.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-march=sapphirerapids
is supported only with g++-12 and above and adding conditional compile in Make is non trivial, at least to me :) The main build system is Meson anyway which handles this relatively easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just you 😁 . "Read the docs, provide path to compiler that support the following flags" is about all you can do with a custom Makefile.
src = include_directories('src') | ||
bench = include_directories('benchmarks') | ||
utils = include_directories('utils') | ||
tests = include_directories('tests') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can all be assigned to one variable, using a single include_directories()
invocation with an array.