Skip to content

Mark partial_qsort<_Float16> as maybe_unused #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

Mark partial_qsort<_Float16> as maybe_unused #215

merged 1 commit into from
Sep 11, 2025

Conversation

r-devulap
Copy link
Member

NumPy doesn't need this function and caused a CI failure:

In file included from ../numpy/_core/src/npysort/x86_simd_qsort_16bit.dispatch.cpp:4:
../numpy/_core/src/npysort/x86-simd-sort/src/x86simdsort-static-incl.h:193:6: error: ‘void x86simdsortStatic::partial_qsort(T*, size_t, size_t, bool, bool) [with T = _Float16]’ defined but not used [-Werror=unused-function]
  193 | void x86simdsortStatic::partial_qsort<_Float16>(

@r-devulap r-devulap merged commit 8f80b71 into numpy:main Sep 11, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@r-devulap