Update build configuration to reduce friction #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems with glibc < 2.34, the `-lpthread` option needs to be included when linking with Google's benchmark and test frameworks. However, the `pkg-config` command for `benchmark` needs to be explicitly given the `--static` flag for this to be included. The static inclusion has also been added to the Meson configuration. I've also included some rudimentary logic to allow the Makefile to shrink the scope of its compilation targets when an older compiler is being used. I changed the benchmarks to run using `benchmark_main` in the same way that the tests use `gtest_main`. Finally, I turned off compilation of the package-internal tests for Google Benchmarks when running in GitHub actions.
r-devulap
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I got annoyed that my Ubuntu 20.04 machine couldn't compile the benchmarks so I looked into it. I also updated the Makefile to have some available compiler smarts like Meson. Closes #44.
On systems with glibc < 2.34, the
-lpthreadoption needs to be included when linking with Google's benchmark and test frameworks. However, thepkg-configcommand forbenchmarkneeds to be explicitly given the--staticflag for this to be included. The static inclusion has also been added to the Meson configuration.I've also included some rudimentary logic to allow the Makefile to shrink the scope of its compilation targets when an older compiler is being used. I changed the benchmarks to run using
benchmark_mainin the same way that the tests usegtest_main. Finally, I turned off compilation of the package-internal tests for Google Benchmarks when running in GitHub actions.