ErrorException : Uninitialized string offset: 1

[LeonAlvarez]

Q	A
Bug report?	yes
Feature request?	no
Library version	1.3.0

PHP 7.2.16 Laravel 5.8.10

   ErrorException  : Uninitialized string offset: 1

  at /var/www/project/vendor/nunomaduro/phpinsights/src/Domain/Analyser.php:314
    310|                     break;
    311| 
    312|                 case \T_STRING:
    313|                     if ($value === 'define'
  > 314|                         && $tokens[$i - 1][1] !== "::"
    315|                         && $tokens[$i - 1][1] !== "->"
    316|                         && (! isset($tokens[$i - 2][1]) || $tokens[$i - 2][1] !== 'function')) {
    317| 
    318|                         $j = $i + 1;

  Exception trace:

  1   Illuminate\Foundation\Bootstrap\HandleExceptions::handleError("Uninitialized string offset: 1", "/var/www/project/vendor/nunomaduro/phpinsights/src/Domain/Analyser.php")
      /var/www/project/vendor/nunomaduro/phpinsights/src/Domain/Analyser.php:314

  2   NunoMaduro\PhpInsights\Domain\Analyser::analyseFile(Object(NunoMaduro\PhpInsights\Domain\Collector), "/var/www/project/xxxx/xxxx/xxxxx/js-plugins/jqGrid/PHP/jqForm.php")
      /var/www/project/vendor/nunomaduro/phpinsights/src/Domain/Analyser.php:55

[nunomaduro]

Can you output print the value of $tokens when that happens ?

[LeonAlvarez]

When it happens $i is 972 and $tokens is:
968 => array ( 0 => 323, 1 => '"P\\x48\\x50\\x53\\x55IT\\x4f\\x5f\\x52\\x4f\\x4fT"', 2 => 5, ), 969 => ')', 970 => ')', 971 => '{', 972 => array ( 0 => 319, 1 => 'define', 2 => 5, ), 973 => '(', 974 => array ( 0 => 323, 1 => '"PHPS\\x55IT\\x4f_\\x52O\\x4fT"', 2 => 5, ),

[LeonAlvarez]

Issue was caused in some really legacy code wich is not intented to be analyzed anyway, fixed by excluding that files