Skip to content

Conversation

kontaras
Copy link
Contributor

@kontaras kontaras commented Sep 24, 2024

alias curl="curl -s -k -u \"${NUODB_CP_USER}:${NUODB_CP_PASSWORD}\""
```

### Setting up the Terraform Provider
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this subsection providing context for the terraform examples that show below? Is there anything we want to say here about where the configuration snippets should be inserted, e.g. into the same configuration that has the provider?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters where in their terraform configuration the customer puts any given snippet. Terraform evaluates files in indeterminate order.

}
provider "nuodbaas" {
# The provider does not support self signed certificates.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to call this out as a limitation. The line below is sufficient to explain why this is necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also reordered the second sentence since it is carrying more meaning now.

### Setting up the Terraform Provider

To use terraform to manage your databases, you will want to use the [`nuodbaas` provider](https://registry.terraform.io/providers/nuodb/nuodbaas).
The [provider documentation](https://registry.terraform.io/providers/nuodb/nuodbaas/latest/docs#schema) covers all of the attributes you can define but, if they are not set, the provider can infer a configuration using the environment variables set above.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the " but," with a period? It flows better to split it into two separate sentences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit of a run on. I will split it.

Copy link
Collaborator

@adriansuarez adriansuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@sivanov-nuodb sivanov-nuodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kontaras kontaras merged commit 7a5f291 into main Sep 27, 2024
2 checks passed
@kontaras kontaras deleted the kontaras/terraform-initial branch September 27, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants