Update msi install and uninstall checking script

[hustcer]

No description provided.

[github-actions]

Here's my analysis of the code changes:

Script Analysis

• Key observations:
  • New common.nu module introduced for shared test functionality
  • Extraction of common installation verification logic into reusable commands
  • Support for both user and machine scope installations
  • Consolidated binary and asset checks into shared functions
  • Improved registry query handling
  • Better environment variable path management

Security Review

• Vulnerability findings:
  • ❗ Registry queries in common.nu could fail silently if values don't exist (line 27, 44)
  • ⚠️ Path concatenation in $'($nu.home-path)\AppData\...' could be injection vulnerable if home-path contains malicious characters
  • ⚠️ No input validation in exported functions for install_dir parameter

Optimization Suggestions

• Performance improvements:
  • Cache repeated registry queries in common functions
  • Use par-each for checking multiple binary/asset existence
  • Replace string interpolation with path join for safer path construction
  • Add lazy evaluation for expensive operations like environment variable parsing

Overall Quality: 4 (Very good with minor security and performance improvements needed)

The refactoring to use a shared module is excellent for maintainability and follows Nu best practices. The security issues are relatively minor but should be addressed, and there are several opportunities for performance optimization in the verification logic.