-
Notifications
You must be signed in to change notification settings - Fork 293
refactor powerline script #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- get_component - when there is only one component in left, '>>' takes precedence - use `reduce` instead of `each & filter` (improved performance significantly)
Can you please give the PR a more descriptive title so the people that might want to take a look can find it. |
@fj0r We can land this one, since I've been following your work, but rather than 100 PRs, maybe you should try to get things working the way you want and then submit a PR. Also, like I've said before, we need more descriptive text about what you're doing in the PR and with a proper title. Thank you for understanding! |
Sorry. I'm not sure how detailed this description is, it's probably longer than the code if you don't miss relevant points.
Because the prompt response is slow, which greatly affects the experience, so this part is more important I'm not sure if this is verbose as these are obvious things Overall, I thought it was just a little toy, as long as it finally works, there is no need to pay too much attention to the details of its internals. (That is to say, I thought that not many people would pay attention to this thing, until one day, they saw someone using powerline in zsh on youtube, and wanted to try it in nushell) |
|
just to be clear, we don't require multiple paragraphs to detail what is changed. what we'd like to see is a high level description of what the PR is changing, what is going on. if there are breaking changes for users, we'd like a little more detail. we also want a proper pr title. e.g. this title was "refactor". that's too vague. i changed it to "refactor powerline script" which is probably good enough. |
|>
for head of left