Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remaining aliases #495

Merged
merged 4 commits into from
May 16, 2023
Merged

Fix: remaining aliases #495

merged 4 commits into from
May 16, 2023

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented May 16, 2023 •
edited
Loading

I am not sure about aws: why it's in aliases/ directory?

EmilySeville7cfg added 2 commits May 16, 2023 23:29
fix(alias): exa
8e0835f 
- reformat
feat(alias): aws
f5423d5 
- fix errors
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as draft May 16, 2023 13:39
fix(aliases): clean-up
e984fc1 
- create universal README
- remove redundant files
- rename modules
@EmilyGraceSeville7cf EmilyGraceSeville7cf marked this pull request as ready for review May 16, 2023 13:43
@fdncred
Copy link
Collaborator

fdncred commented May 16, 2023

agreed, it should be in a modules directory.

fix(aliases): aws
57e8dd1 
- move to modules/
@fdncred fdncred merged commit f86a060 into nushell:main May 16, 2023
@fdncred
Copy link
Collaborator

fdncred commented May 16, 2023

Thanks!

@EmilyGraceSeville7cf
Copy link
Contributor Author

So quickly. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilyGraceSeville7cf @fdncred