Skip to content

Conversation

fj0r
Copy link
Contributor

@fj0r fj0r commented Jan 4, 2024

  • README.md: delete the content of template and replace it with a link
  • comma_test: T/F execute a closure and return a true or false
  • comma_tmpl: add example of building image

- README.md: delete the content of template and replace it with a link
- comma_test: T/F execute a closure and return a true or false
- comma_tmpl: add example of building image
@fj0r fj0r marked this pull request as ready for review January 4, 2024 01:00
@fdncred
Copy link
Contributor

fdncred commented Jan 4, 2024

i don't plan on landing anymore after this one for the reasons we've talked about many times.

@fj0r
Copy link
Contributor Author

fj0r commented Jan 4, 2024

Okay, I'll create a separate repository to house it. However, I don't understand what is the essential difference between comma and other scripts, so that it cannot be put here. Is there a clear rule?

@fdncred
Copy link
Contributor

fdncred commented Jan 4, 2024

As we've discussed before, the rule is, this is not your personal repository. It's for sharing interesting scripts with others, not doing development on scripts.

@fj0r
Copy link
Contributor Author

fj0r commented Jan 4, 2024

It was actually used for development purposes before, and I didn't mean to do that. But now that it's done and all that's left is patching, is that okay?

@fj0r
Copy link
Contributor Author

fj0r commented Jan 4, 2024

I'd better create a new repo, excuse me.

@fdncred
Copy link
Contributor

fdncred commented Jan 4, 2024

i'll land this when you tell me it's ready.

@fj0r
Copy link
Contributor Author

fj0r commented Jan 4, 2024

So do I need to create a new repository? I think there may not be any major updates in the future (however, I can’t guarantee it), and updates may not occur more than once a month.
But if I create a new repo, I may have to adjust the module structure and maybe configure the package management system, otherwise it may be more troublesome for me to use it myself (I may need to introduce submodules into my git configuration file)

@fdncred
Copy link
Contributor

fdncred commented Jan 4, 2024

I suggest you create a repo with all your scripts. This isn't the first one that you've developed in our repo. You should develop and continue to tweak your neat scripts in your repo until the point that you think they're done. Then, if you want to share them with the nushell community, you can share here.

@fj0r
Copy link
Contributor Author

fj0r commented Jan 4, 2024

Alright, I got it.

@fj0r
Copy link
Contributor Author

fj0r commented Jan 5, 2024

Improved README.md and I think it will not be updated recently, please merge it

@fdncred fdncred merged commit 0632778 into nushell:main Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants