-
Notifications
You must be signed in to change notification settings - Fork 525
Add real Nushell syntax highlighting support #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nice work @hustcer. I'll be excited to see this (if 522 ever lands). I appreciate all your attention to our docs. Thank you so much! |
8acab10
to
15d6c04
Compare
What's the deal with shiki? Do they not accept PRs very often? |
They may accept it after a while, no one is taking care of the PRs now. And we can't wait for them for the uncertainty, we can add a patch as a workaround now and remove the patch if the PR got merged later. |
Thanks for pushing this forward @hustcer Are there special rules in the grammar for how a table or prompt should look like? Looking at a random assortment of prompts sometimes it highlights the code after a |
@sholderbach I'm simply using The Same Nu Grammar as the VS Code Plugin Here, maybe @fdncred knows? |
It's a regex fest for the grammar. It should behave identically, as far as syntax checking, as the extension. So, you could test by putting a |
The page looks generally fine even when prefixed with the |
Also, the tables look a bit weird because the column names seem green-ish. Wondering if they should be in their own code fence? |
It's better to update the grammar file to make those strings with |
Try to Add real Nushell syntax highlighting support to Nushell official site:
It may take a bit longer though let's just get started, the detailed plan:
Shiki
asVuepress
's syntax highlighter;nushell
grammar shikijs/shiki#522 haven't get merged;```nushell ```
or```nu ```
;