Skip to content

Extend globbing section in moving_around.md #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

Extend globbing section in moving_around.md #1125

merged 1 commit into from
Dec 12, 2023

Conversation

mb21
Copy link
Contributor

@mb21 mb21 commented Oct 23, 2023

from nushell/nushell#10749 (comment):

Yep, no glob documentation in the book, perhaps you'd like to take a crack at writing it?

@mb21 mb21 mentioned this pull request Oct 23, 2023
Closed
mb21
mb21 commented Oct 23, 2023
View reviewed changes
amtoine
amtoine reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i read that and it looked correct 👌

i'd like to have the input of other folks from the core team just to be sure it's correct 😌

@mb21
Copy link
Contributor Author

mb21 commented Oct 23, 2023

@amtoine sure, it's mostly paraphrased from nushell/nushell#10749 (comment) and following comments :)

@fdncred fdncred merged commit a5f253a into nushell:main Dec 12, 2023
@fdncred
Copy link
Contributor

fdncred commented Dec 12, 2023

Thanks!

@mb21 mb21 deleted the patch-1 branch December 13, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtoine amtoine amtoine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mb21 @fdncred @amtoine