Generate plugin banner for all plugin commands #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This is branched from #1518 - Best to merge that first if possible. |
hustcer
reviewed
Aug 21, 2024
|
Thanks for the fix, the plugin docs have already been updated: https://www.nushell.sh/commands/docs/polars.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1515
Previously, a few commands were hard-coded as being plugin commands, and a banner was generated for the command doc accordingly. This was out-of-date, as not even Polars was showing up properly. There's still code to generate a warning for
dfrcommands. (Oops - Forgot to take this out - Brb.) (Okay - Done)After this change,
plugin listis used to return a list of plugin commands, and if a command is in that list, the banner is added.Example: