Skip to content

Document pre_execution use of commandline command #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

Document pre_execution use of commandline command #1888

merged 1 commit into from
Apr 26, 2025

Conversation

Kissaki
Copy link
Contributor

@Kissaki Kissaki commented Apr 26, 2025

Resolves #1827

sholderbach
sholderbach approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be argued that this is close to some cookbook example but I think each chapter should contain some practical nugget so I like this

@fdncred fdncred merged commit 54e3bc2 into nushell:main Apr 26, 2025
2 checks passed
@fdncred
Copy link
Contributor

fdncred commented Apr 26, 2025

Looks good as a primer. Thanks!

@Kissaki Kissaki deleted the feat/preexechook branch April 27, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sholderbach sholderbach sholderbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to receive commandline as part of pre_execution hook
3 participants
@Kissaki @fdncred @sholderbach