Report and forgive missing plugins in make_docs.nu #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could lead to incomplete documentation which I wouldn't be in favor of. |
|
Should it run through and do nothing, or is an exit call fine? When I used exit and called it via nu make_docs.nu it seemed to exit the parent too. |
|
I'll leave it for @hustcer to decide what he wants to do since he regenerates docs |
|
Thanks, I can accept this change, and I won't create the PR if any error happens next time. |
jexjws
pushed a commit
to jexjws/nushell.github.io
that referenced
this pull request
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example screenshot of constructed error case:
Resolves #2010
I would have preferred an error exit, but I'm not sure how to do that in a way that it works for this script both when calling it as a script via
nuas well as when running it viasourcethenmake_docscommand.Checking for invalid paths, reporting them and skipping them seems like a reasonable improvement, especially in the context of #2010 (runtime errors further down the script and command pipeline).