Skip to content

Add husky and prettier to format code automatically while committing code #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented Mar 27, 2022

This is a huge change: add husky and prettier to format code automatically while code committing, do npm i after pulling the latest code. This PR could be rejected if we don't want code formatting

@hustcer hustcer requested a review from sophiajt March 27, 2022 00:58
@rgwood
Copy link
Contributor

rgwood commented Mar 27, 2022

Cool! How long does it take for the code formatter to run?

@hustcer
Copy link
Contributor Author

hustcer commented Mar 27, 2022

Cool! How long does it take for the code formatter to run?

Don't worry, only the modified docs will be formatted while committing, that will take less than 1 sec. For a full formatting please run npm run pretty and it will take about 10 seconds. We need the full formatting only once.

@sophiajt
Copy link
Contributor

Oh wow! That's pretty big.

I think with the auto-generated command docs -- if we haven't already, we could update the script to output something that's more style-conforming.

@sophiajt sophiajt merged commit 89a88fe into nushell:main Mar 27, 2022
@hustcer
Copy link
Contributor Author

hustcer commented Mar 27, 2022

Oh wow! That's pretty big.

I think with the auto-generated command docs -- if we haven't already, we could update the script to output something that's more style-conforming.

agree,i will update it later

@hustcer hustcer deleted the feature/fmt branch March 29, 2022 06:31
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
* ssh kubernetes docker git just nvim

* avoid null when cache ssh

* docker cp & kubectl cp & scp

Co-authored-by: agent <agent@nuc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants