Skip to content

Fix search box style, make it wider #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented Jun 3, 2022

Fix search box style, make it wider

@hustcer hustcer marked this pull request as ready for review June 3, 2022 05:22
@hustcer hustcer merged commit 12ec831 into nushell:main Jun 3, 2022
@hustcer hustcer deleted the opt/search branch June 3, 2022 05:28
@fdncred
Copy link
Contributor

fdncred commented Jun 3, 2022

It's not very wide on safari. Not sure why.
Screen Shot 2022-06-03 at 7 42 38 AM

@hustcer
Copy link
Contributor Author

hustcer commented Jun 3, 2022

It seems that it's in mobile mode not PC mode

@fdncred
Copy link
Contributor

fdncred commented Jun 3, 2022

It seems that it's in mobile mode not PC mode

that's weird. I'm on my Mac.

@hustcer
Copy link
Contributor Author

hustcer commented Jun 3, 2022

I think you didn't take a snapshot for the full nav bar. The search box is wider than before, however, it needn't be tooooo wide, there is no need to to that

@fdncred
Copy link
Contributor

fdncred commented Jun 3, 2022

ya, it wasn't the full bar - just enough to help you see how short the search box was. here's the full bar.
Screen Shot 2022-06-03 at 8 14 07 AM

it just looks small to me. it works fine though. if this is the way it's supposed to be then that's fine.

@hustcer
Copy link
Contributor Author

hustcer commented Jun 3, 2022

I think It's okay, and will work fine on your mobile phone, we should consider for various kinds of devices

ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
* Update ReadMe.md

Added explanation of how to use new --threads switch to feed to the par-each loops

* Update nupass.nu

Added --threads flag to allow setting of same in par-each loops, for performance fine tuning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants