Skip to content

Use auto-generated docs and show usage information in frame layout #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2020

Conversation

arashout
Copy link

Summary:

  • Use yaml file inside _data directory to display documentation for the commands
  • The documentation is displayed using a frame layout with a scrolling layout

It's still not perfect... but I think it's an improvement
Future work could be to use categorization instead of just listing all the commands as @kubouch mentioned on discord
ezgif com-video-to-gif

Use yaml from autogenerated documentation
@arashout arashout requested a review from thegedge July 23, 2020 16:09
Copy link

@thegedge thegedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally, and all looks good. I think we may want to make some styling tweaks and whatnot, but I think we can go ahead with this PR and forward improve. I'm hoping one day all of this can disappear, and we just embed a WASM help shell 🙂

<button class="row__item button grow"
onclick="toggleFrame('{{ sub_command.name | replace: ' ', '_' }}-usage')">{{ sub_command.name }}</button>
</li>
{% endfor %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think subcommands should just be shown on the same level as the other commands, without having to click an "expand" button to see them. I'm thinking the fewer clicks one has to make, the better. It also will be easier to work with if subcommands ever have subcommands, which have subcommands... 😅

What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense. There's just a lot of sub-commands.
But I'm good with either and can change it

Copy link

@thegedge thegedge Jul 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just a lot of sub-commands.

Yeah let's keep it simple for now and not hide them by default, and return to this decision if things really get out of hand.

[EDIT]
As you mentioned in your description, maybe we'll find a way to categorize them, or maybe we'll just dramatically change how we present this information (e.g., embed a WASM nushell in help mode).

Copy link

@thegedge thegedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me as a starting point. I'm starting to think that this quick command reference should almost be in a different layout than the rest of the site 🤔

Something to worry about for another day. Thanks, @arashout !

@arashout
Copy link
Author

Cool, I don't mind doing more work on the website, if I can work off your wireframes.

@arashout arashout merged commit de77e92 into nushell:master Jul 26, 2020
@arashout arashout deleted the sidebar-docs branch July 26, 2020 22:48
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants