Skip to content

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Aug 4, 2022

In this PR, I have replaced all occurences of some old and broken links to the default config files.

These files are now default_config.nu and default_env.nu and the book did not link to these new locations on some pages 😕

I've run global pattern searches to make sure:

Hope you'll find that usefull 😌
cheers 🎉

In this commit, i've `grep`ed all the files containing either
(1) "/default_config.nu" or (2) "/default_env.nu".
The links did point to either
https://github.com/nushell/nushell/blob/main/docs/sample_config/default_*.nu
or
https://github.com/nushell/nushell/blob/main/src/sample_config/default_*.nu
However, these files do not exist anymore from recent commits and
the links are broken in the book itself...

I double checked and the only location where one can find the
default config files is now in
https://github.com/nushell/nushell/blob/main/crates/nu-utils/src/sample_config/default_*.nu

This commit replaces all occurences of the old and broken links to
their new locations in nushell/nushell.
@fdncred
Copy link
Contributor

fdncred commented Aug 4, 2022

thanks

@fdncred fdncred merged commit 65dd124 into nushell:main Aug 5, 2022
@amtoine amtoine deleted the fix/link-to-correct-default-files branch August 5, 2022 17:12
@amtoine
Copy link
Member Author

amtoine commented Aug 5, 2022

your're welcome 😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants