Skip to content

Conversation

chrjen
Copy link
Contributor

@chrjen chrjen commented Sep 5, 2022

'Duration' and 'File sizes' sections were incomplete with values missing.

For the duration 1month I wrote "30 days" for clarification. A month can be anywhere from 28–31 days depending on the month while the program always seems to treat a month as 30 days.

@fdncred
Copy link
Contributor

fdncred commented Sep 5, 2022

good catch. I'd also add that leap years are not calculated at all. no leap days, leap hours, leap seconds, no leap anything. So, a year, I believe is calculated at 365 days always. feel free to update year as 365 days if you want.

'Duration' and 'File sizes' sections were incomplete with values missing.

For the duration `1month` I wrote "30 days" for clarification. A month can be anywhere from 28–31 days depending on the month while the program always seems to treat a month as 30 days.
@chrjen
Copy link
Contributor Author

chrjen commented Sep 5, 2022

good catch. I'd also add that leap years are not calculated at all. no leap days, leap hours, leap seconds, no leap anything. So, a year, I believe is calculated at 365 days always. feel free to update year as 365 days if you want.

That is a little more tricky since year and decade are both abbreviated. I have updated the PR with some changes. I decided to simply write the name and instead put the actual length in days in parenthesis. Hopefully this is good.

@fdncred
Copy link
Contributor

fdncred commented Sep 5, 2022

yup, lgtm. thanks

@fdncred fdncred merged commit 00479c0 into nushell:main Sep 5, 2022
sophiajt added a commit that referenced this pull request Sep 6, 2022
* add 68 blog

* add string distance and named durations

* Upgrade all vuepress plugins and fix doc search navigation by pressing `enter` key (#587)

* Upgrade  all vuepress plugins and fix doc search navigation by pressing `enter` key (#586)

* chore: upgrade vuepress plugins fix doc search navigation by enter key

* Update ci workflow

* chore: update ci

* chore: update ci

* Upgrade vuepress and all related plugins to improve build performance (#588)

* Breaking change note: dequestionmarked commands

Depends on landing nushell/nushell#6464

* Update types_of_data.md with missing values (#589)

'Duration' and 'File sizes' sections were incomplete with values missing.

For the duration `1month` I wrote "30 days" for clarification. A month can be anywhere from 28–31 days depending on the month while the program always seems to treat a month as 30 days.

* Update former question mark commands in docs (#590)

Account for nushell/nushell#6464

`any?`/`all?`/`empty?` to `any`/`all`/`is-empty`

* Document path split breaking change

* Add Homebrew PATH documentation

* Add module and overlay changes

* Reword source change; Add config table entries

* Rewrite dequestionmarking

* Oops

* More rewording

* Reformulate next steps

* Add links

* Add external completer section

* Update 2022-09-06-nushell-0_68.md

Co-authored-by: Justin Ma <hustcer@outlook.com>
Co-authored-by: sholderbach <sholderbach@users.noreply.github.com>
Co-authored-by: Christer Jensen <chr.code@gmail.com>
Co-authored-by: Reilly Wood <reilly.wood@icloud.com>
Co-authored-by: kubouch <kubouch@gmail.com>
Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
* fix indexing issue

* [bar] make default output without ansi codes

* [bar] use actual testing framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants