Skip to content

Conversation

Tengs-Fan
Copy link
Contributor

No description provided.

Copy link
Contributor

@rgwood rgwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Added some suggestions.

In the future, I think that piping a list<string> to an external command should just work - we shouldn't need to text. I'll raise an issue for that.

Tengs-Fan and others added 2 commits December 22, 2022 15:05
Co-authored-by: Reilly Wood <26268125+rgwood@users.noreply.github.com>
Co-authored-by: Reilly Wood <26268125+rgwood@users.noreply.github.com>
@rgwood rgwood merged commit 9423b53 into nushell:main Dec 22, 2022
@Tengs-Fan Tengs-Fan deleted the patch-3 branch December 22, 2022 23:10
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
I added completions for
- [x] `gh repo clone`
    - [x] <tab> gives you a list of your repositories on github
- [x] `gh repo create`
    - [x] `--ignore <tab>` gives you a list of gitignores
- [x] `--license <tab>` gives you a list of licenses with their
description
    
- [x] `gh repo fork` flags

Compared to previous PRs on `gh` completion, it's not much, but these
features are those I use most of the time.
If you want to have completions of some particular subcommand, feel free
to ask!

## Samples

![image](https://github.com/nushell/nu_scripts/assets/30557287/96ddb487-f65b-4f6d-9aed-4ef3be140db7)


![image](https://github.com/nushell/nu_scripts/assets/30557287/3f3ccd5d-1b24-4b05-94e3-c980a0badbf5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants