Skip to content

Add separate page for setting Nu as default shell #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

Hofer-Julian
Copy link
Contributor

  • Adds instructions to add Nu to your terminal
  • Advises against setting Nu as login shell

Heavily inspired by
https://elv.sh/get/#using-elvish-as-your-default-shell

- Adds instructions to add Nu to your terminal
- Advises against setting Nu as login shell

Heavily inspired by
https://elv.sh/get/#using-elvish-as-your-default-shell
@fdncred
Copy link
Contributor

fdncred commented Jan 28, 2023

I like the changes except that the part that says "We do not recommend setting your login shell to Nu.". I use it as my login shell in WSL2 every weekday without issue. I can understand that we may need to say something but I don't want to deter people from using nushell, just the opposite.

I think it's ok to have a warning but I think we should use different words. Perhaps like "Warning, Nu is still in development and is not intended to be POSIX compliant. If you need strict POSIX compliance at login time, you should consider using a alternate login shell."

Maybe not those exact words, but something less like "Don't use nushell" 😆

@Hofer-Julian
Copy link
Contributor Author

Maybe not those exact words, but something less like "Don't use nushell"

I understand what you are saying, and I also want people to use nushell.
Even as their default shell, which is why I've added the terminal instructions.

If you need strict POSIX compliance at login time

Unfortunately, that's not something you can choose.
There are just too many programs who just assume that your login shell is POSIX compliant, and the error messages tend to be very bad and/or hidden somewhere in the logs.

Some friends noticed that also with some vscode extensions, so that problem probably also occurs on WSL and macOS.

If you still want me to weaken the message or add alternative "default methods" (see https://wiki.archlinux.org/title/Fish), I am happy to.

@fdncred
Copy link
Contributor

fdncred commented Jan 28, 2023

Yes, it needs to be similar to what I suggested please. I don't want to discourage use.

@Hofer-Julian
Copy link
Contributor Author

Updated it to:

Nu is still in development and is not intended to be POSIX compliant.
Be aware that some programs on your system might assume that your login shell is POSIX compatible.
Breaking that assumption can lead to unexpected issues.

How do you like that one?

@fdncred
Copy link
Contributor

fdncred commented Jan 28, 2023

Much better. Thank you.

@fdncred
Copy link
Contributor

fdncred commented Jan 28, 2023

One last thing, Do you think the installation page should have a link to the default_shell page? I could go either way.

@Hofer-Julian
Copy link
Contributor Author

vuepress does that for us at the very end of the page.
I feel like that is sufficient :)

grafik

@fdncred fdncred merged commit 2eaf576 into nushell:main Jan 28, 2023
@Hofer-Julian Hofer-Julian deleted the default-shell branch January 28, 2023 19:21
@rgwood
Copy link
Contributor

rgwood commented Jan 28, 2023

Thanks for improving the docs!

ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
These are the changes after running nu_deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants