Skip to content

add #8366 to the release notes #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2023
Merged

add #8366 to the release notes #848

merged 4 commits into from
Apr 4, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Apr 1, 2023

a little note to explain the new --indent, --tabs and --raw options for outputting NUON data 😋

see nushell/nushell#8366

@amtoine
Copy link
Member Author

amtoine commented Apr 4, 2023

conflicts solved 😏 👍

@@ -118,6 +123,47 @@ The `error make` command now gives better hints about why the format is not a va

The second change disallow the use of a `$.label.start` greater than `$.label.end` as a span.

## on the `NUON` format ([amtoine](https://github.com/nushell/nushell/pull/8366))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The titles should be explicit and informative for the reader.

Suggested change
## on the `NUON` format ([amtoine](https://github.com/nushell/nushell/pull/8366))
## Support for pretty output format in `to nuon` ([amtoine](https://github.com/nushell/nushell/pull/8366))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing it right now 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 2fd75ee

@@ -118,6 +123,47 @@ The `error make` command now gives better hints about why the format is not a va

The second change disallow the use of a `$.label.start` greater than `$.label.end` as a span.

## on the `NUON` format ([amtoine](https://github.com/nushell/nushell/pull/8366))

The `to nuon` command can now output "_pretty_" `NUON` data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use fixed width formatting for NUON in the https://www.nushell.sh/book/loading_data.html#nuon

Suggested change
The `to nuon` command can now output "_pretty_" `NUON` data.
The `to nuon` command can now output _pretty_ NUON data with whitespace for better readability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha 👌

done in a5332f0 👍

@sholderbach sholderbach merged commit 9925e60 into nushell:release-notes-0.78 Apr 4, 2023
sophiajt added a commit that referenced this pull request Apr 4, 2023
* Release notes for `0.78`

Please add your new features and breaking changes to the release notes
by opening PRs against the `release-notes-0.78` branch.

* Document optional cell path members

* Add placeholders

* Mention empty list changes

* Mention comparison operator breaking change

* add a note about better `error make` (#849)

* Update 2023-04-04-nushell_0_78.md

* Update 2023-04-04-nushell_0_78.md

* Update 2023-04-04-nushell_0_78.md

* Update 2023-04-04-nushell_0_78.md

* Update 2023-04-04-nushell_0_78.md

* Update 2023-04-04-nushell_0_78.md

* Mention added `math exp`

* Update 2023-04-04-nushell_0_78.md

* Expand alias changes

* add #8366 to the release notes (#848)

* add #8366 to the release note

* make the title more explicit for the reader

* be more explicit about what "pretty format" means

* fix nuon quoting

* Update 2023-04-04-nushell_0_78.md

---------

Co-authored-by: Reilly Wood <reilly.wood@icloud.com>
Co-authored-by: Antoine Stevan <44101798+amtoine@users.noreply.github.com>
Co-authored-by: JT <547158+jntrnr@users.noreply.github.com>
Co-authored-by: Jakub Žádník <kubouch@gmail.com>
@amtoine amtoine deleted the release-note/pretty-format-for-to-nuon branch April 5, 2023 16:18
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants