Skip to content

Fix some typos and other nits to the variable documentation #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Fix some typos and other nits to the variable documentation #881

merged 1 commit into from
Apr 23, 2023

Conversation

MariaSolOs
Copy link
Contributor

As the title advertises.

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @MariaSolOs 😊

@sophiajt sophiajt merged commit a3ece36 into nushell:main Apr 23, 2023
@MariaSolOs MariaSolOs deleted the variable-docs branch April 23, 2023 15:04
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
I changed `export-env {}` at the beginning to a custom command to avoid
having `export-env` run when loading the module
  because:
1. I couldn't use `nu_msvs activate` because it depends on env vars
being set that were hidden with `nu_msvs deactivate`
2. It seems that `export-env` executed at `use`, leaves `$env.FILE_PWD`
available in the environment which I think may be
     a bug. So, putting it in a custom command avoids that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants