Skip to content

Conversation

hustcer
Copy link
Contributor

@hustcer hustcer commented May 25, 2023

Remove unnecessary 0.59 binaries, It's old and outdated

@fdncred
Copy link
Contributor

fdncred commented May 25, 2023

This is the only copy we have of these files. Is there somewhere we can place them, like in a release somewhere, so we don't lose them?

@hustcer
Copy link
Contributor Author

hustcer commented May 25, 2023

If you just want to backup them somewhere and don't care about where they are, I think I can create a release here https://github.com/hustcer/nu-release/releases and upload these binaries
We can also upload them to https://github.com/nushell/nushell/releases, I'm afraid there will be some side effects

@fdncred
Copy link
Contributor

fdncred commented May 25, 2023

can we put them in the releases of this repo?

@hustcer
Copy link
Contributor Author

hustcer commented May 25, 2023

can we put them in the releases of this repo?

Yes, but this repo need to be cleaned, and all the tags will be removed after the clean, not sure whether the release will be affected or not

@fdncred
Copy link
Contributor

fdncred commented May 25, 2023

what about uploading those binaries as an old release, after it's cleaned?

@hustcer
Copy link
Contributor Author

hustcer commented May 25, 2023

Okay, BTW: we will create a backup of this repo before it been cleaned and these binaries could be found there too

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all fine with me if it speeds up git cloneing 👌

@hustcer hustcer merged commit 52d1a3f into nushell:main May 26, 2023
@hustcer hustcer deleted the fix/remove-bin branch May 26, 2023 01:48
@hustcer hustcer mentioned this pull request May 26, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants