Skip to content

remove all | table from the book #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jul 9, 2023

related to

with the display_output out of the way by default in nushell/nushell#9633, we do not need anymore to pass big tables in table to make sure the hook does not trigger table -e

Commands used:

sd ' ?\| table$' '' **/*
git restore commands/

Command used:
```nushell
sd ' ?\| table$' '' **/*
git restore commands/
```
@@ -79,7 +79,7 @@ In effect, the command:
And the pipeline:

```
> ls | table
> ls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change this one as it explains how | table is added for you automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good catch, thanks @jntrnr 😱

should be fixed in f3fd7eb 👍

Copy link
Member Author

@amtoine amtoine Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've also added a note about ls and ls | table being one and the same in 17597f9, this is not entirely true and caused more confusion in nushell/nushell#9630 🤔

@amtoine
Copy link
Member Author

amtoine commented Jul 18, 2023

now that nushell/nushell#9676 has landed, i think this is ready 😋

@fdncred fdncred merged commit 82ceb7b into nushell:main Jul 18, 2023
@amtoine amtoine deleted the remove-table-end-of-pipe branch July 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants