Skip to content

refactor ssh-agent cookbook example #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2023
Merged

refactor ssh-agent cookbook example #982

merged 4 commits into from
Jul 21, 2023

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jul 17, 2023

this PR hopefully makes the ssh-agent example in the cookbook easier to read 😇

i've also removed the note about ssh-add as it does not appear to be useful at all 🤔
i use this ssh-agent everyday without ever running ssh-add 😕

@amtoine amtoine mentioned this pull request Jul 17, 2023
Closed
sholderbach
sholderbach approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be good, (man are those transpose options confusing for my taste)

@sholderbach sholderbach merged commit 68b315e into nushell:main Jul 21, 2023
@amtoine amtoine deleted the refactor-ssh-agent-cookbook-example branch July 21, 2023 08:47
@amtoine
Copy link
Member Author

amtoine commented Jul 21, 2023

man are those transpose options confusing for my taste

yeah i agree 😆
i always have to play with the combinations of -r, -i and -d to get what i want 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sholderbach sholderbach sholderbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amtoine @sholderbach