Skip to content

Conversation

Heidar-An
Copy link
Contributor

Some changes to the nushell imperative map, maybe I will try to finish it when i'm procrastinating again

| range | range | .., until, downTo, step | iota | .. |
| reduce | functools.reduce | reduce | reduce | fold, rfold, scan |
| reject | del | | | |
| rename | shutil.move | | | |
| rename | shutil.move | | | fs::rename |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mistake on the python side already. rename doesn't affect the file system but replaces the keys of a table/records

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, yeah, i just looked at the python command. i'll change both now, should I rename keys in hashmaps for both?

a lot of indentation happened here.
@Heidar-An
Copy link
Contributor Author

can we merge now?

@sholderbach sholderbach merged commit 5dec614 into nushell:main Jul 18, 2023
@Heidar-An Heidar-An deleted the patch-1 branch July 18, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants