`(ls | sort-by name)` and other subexpressions lose ls_colors

[fdncred]

Describe the bug

alias ls = (ls | sort-by name)
names are not colored with ls_colors

How to reproduce

see above

Expected behavior

retain ls_colors

Screenshots

No response

Configuration

key	value
version	0.59.0
branch	main
short_commit	b64ac9e
commit_hash	b64ac9e
commit_date	2022-02-16 18:24:45 +00:00
build_os	windows-x86_64
rust_version	rustc 1.58.1 (db9d1b20b 2022-01-20)
rust_channel	stable-x86_64-pc-windows-msvc
cargo_version	cargo 1.58.0 (f01b232bc 2022-01-19)
pkg_version	0.59.0
build_time	2022-02-16 12:33:29 -06:00
build_rust_channel	debug
features	dataframe, default, which, zip
installed_plugins	gstat, inc, nu-example-1, nu-example-2, nu-example-3, query, query json, query web, query xml

Additional context

No response

[sophiajt]

I have a hunch. (ls | sort-by name) also loses it, so I suspect subexpression evaluation is to blame.

[sophiajt]

Yup - eval_subexpression returns a PipelineData, which should be fine. The problem is here:

                eval_subexpression(engine_state, stack, block, PipelineData::new(expr.span))?
                    .into_value(expr.span),

The .into_value will convert PipelineData into a Value, and in doing so will lose the metadata

[fdncred]

ya, you're right.. sometimes?

as an alias

i'm so confused <--- EDIT - it's using the alias here - the first one was not

[sophiajt]

Is that last image after you aliased ls?

[fdncred]

Is that last image after you aliased ls?

yup - i just put an EDIT above it to explain it. But before i aliased it, the colors are there.

[fdncred]

Yup - eval_subexpression returns a PipelineData, which should be fine. The problem is here:

                eval_subexpression(engine_state, stack, block, PipelineData::new(expr.span))?
                    .into_value(expr.span),

The .into_value will convert PipelineData into a Value, and in doing so will lose the metadata

I don't see where there is an available pipelinedata.metdata to use around here. The closest I could find would be maybe using eval_expression_with_input() which has an input with metadata. Am I missing something?