Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CantFindColumn and ColumnAlreadyExists errors #7164

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

webbedspace
Copy link
Contributor

@webbedspace webbedspace commented Nov 19, 2022

Description

  • Changed all CantFindColumn errors to list the column name. This makes the following message more clear:
〉let b = 'c'
〉{a:1} | select $b
Error: nu::shell::column_not_found (link)

  × Cannot find column
   ╭─[entry #12:1:1]
 1 │ {a:1} | select $b
   · ──┬──          ─┬
   ·   │             ╰── cannot find column
   ·   ╰── value originates here
   ╰────

〉

The error is changed to:

  × Cannot find column
   ╭─[entry #11:1:1]
 1 │ {a:1} | select $b
   · ──┬──          ─┬
   ·   │             ╰── cannot find column 'c'
   ·   ╰── value originates here
   ╰────
  • ColumnAlreadyExists errors are changed likewise.

User-Facing Changes

See above.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@rgwood
Copy link
Contributor

rgwood commented Nov 19, 2022

Nice change - I love to see error messages getting better. Thanks.

@rgwood rgwood merged commit 4b83a2d into nushell:main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants