Syntax highlighting of raw strings

[LemmusLemmus]

Currently, raw strings are highlighted as if they were a comment.

let text = r#'raw-string'#; let text2 = "string"

Compare this with how a raw strings are highlighted in e.g. Python.

text = r'raw-string'; text2 = "string"

For reference, in the nushell line editor, raw strings are simply rendered as white (in my terminal at least).

I suggest that raw strings should probably be rendered as either:

• The normal string color.
• As it is in e.g. Python in VSCode, i.e. the r is one color and the rest is another color.
• As it is in the shell (white).

[fdncred]

Where are you talking about? In the repl? In github? In vscode? In nvim?

[LemmusLemmus]

In VSCode (this is the VSCode repo after all, although also in GitHub as is evident by the GitHub markdown). The issue is also visible in the nushell documentation. The highlighting is white in the repl (which I guess is fine, but that is the same color as comments, so it might not be intended). I have not checked in nvim.

Notice that except for the repl, this highlighting implies that any code after it on the same line loses syntax highlighting (since it is highlighted as a comment).

When hovering over the raw string in VSCode, the section that is the raw-string is correctly identified (but not correctly colored).

[fdncred]

this is the VSCode repo after all

lol, i get notifications from a dozen nushell repos. my mistake.

I can't really remember but I think the highlighting is part of the grammar and how tokens are assigned. someone would have to play around with the regexes to try and get it right. I think the strings start here.

vscode-nushell-lang/syntaxes/nushell.tmLanguage.json

Line 16 in 63fcfaf

"string": {

GitHub as is evident by the GitHub markdown

I think GH uses a version of this syntax file too. I'm not sure who keeps it up to date.

[LemmusLemmus]

Yep, the file seems to lack a regex for raw strings. I can give it a try fixing it, provided that I manage to load an extension from source in my Nix managed VSCodium...