Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign nav bar, GlobalSearch, and dropdowns #3155

Open
wants to merge 57 commits into
base: master
Choose a base branch
from
Open

Redesign nav bar, GlobalSearch, and dropdowns #3155

wants to merge 57 commits into from

Commits on Jan 15, 2021

  1. WIP move navtabs into navbar

    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    89cf04f View commit details
    Browse the repository at this point in the history

  2. Don't left align content anymore

    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    bcafd89 View commit details
    Browse the repository at this point in the history

  3. Allow Venues page map to expand

    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    2477848 View commit details
    Browse the repository at this point in the history

  4. Make nav bar white with bottom border 

    White background allows more colors to be used in the nav bar.

Feels like there are too many horizontal lines in the app, but just
playing around for now. We can try fixing this later.
    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    804f20a View commit details
    Browse the repository at this point in the history

  5. Add bottom line to navtabs

    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    8983465 View commit details
    Browse the repository at this point in the history

  6. Replace navbar bottom border with softer shadow

    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    a08cbed View commit details
    Browse the repository at this point in the history

  7. Roughly allow GlobalSearch to expand rightwards

    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    26c7bfc View commit details
    Browse the repository at this point in the history

  8. Implement expanding GlobalSearch

    @taneliang
    taneliang committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    eaaaa29 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    a9b08e4 View commit details
    Browse the repository at this point in the history

  2. Move GlobalSearch to the right

    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    ee2dd72 View commit details
    Browse the repository at this point in the history

  3. Replace top/bottomBar with flex layouts 

    bottomBar was position:relative, which caused it to float above the page
regardless of where its parent nav bar was. This causes the tabs to
stick to the top of the screen when you rubberband-scroll on iOS.

To fix this, this commit brings the tabs inline, laying out the nav bar
using flex magic instead.

This also allows us to easily prevent the search box or other nav
bar components from overlapping with the tabs. Global search is now much
less buggy than before.
    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    fd56f0f View commit details
    Browse the repository at this point in the history

  4. Enlarge logo tappable area

    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    376e410 View commit details
    Browse the repository at this point in the history

  5. Remove $side-nav-width-* variables

    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    9a4448f View commit details
    Browse the repository at this point in the history

  6. Add transition to search box open/close

    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    3628673 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    84800f4 View commit details
    Browse the repository at this point in the history

  8. Only animate opacity for GlobalSearch input to prevent icon jump at e… 

    …nd of exit
    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    79f677c View commit details
    Browse the repository at this point in the history

  9. WIP nav dropdown

    @taneliang
    taneliang committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    3166ff2 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2021

  1. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    bc5d1e6 View commit details
    Browse the repository at this point in the history

  2. Implement NavDropdown

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    3026230 View commit details
    Browse the repository at this point in the history

  3. Add accessory info to dropdown items

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    a68a79a View commit details
    Browse the repository at this point in the history

  4. Remove background color from circles

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    2e2b6d8 View commit details
    Browse the repository at this point in the history

  5. Shorten search placeholder to fit

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    1481aa2 View commit details
    Browse the repository at this point in the history

  6. Move global search dropdown up a little

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    789007a View commit details
    Browse the repository at this point in the history

  7. Fix nav circle and GlobalSearch colors

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    a634ca6 View commit details
    Browse the repository at this point in the history

  8. Enable Navtabs text on lg

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    7c5736e View commit details
    Browse the repository at this point in the history

  9. Fix dropdown divider in planner button

    @taneliang
    taneliang committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    cb43958 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Fix NavDropdown toggle, hover states

    @taneliang
    taneliang committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    2fc54dd View commit details
    Browse the repository at this point in the history

  2. Add NUS Business, rename NUSWhispers, improve right accessory icon color

    @taneliang
    taneliang committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    740bda5 View commit details
    Browse the repository at this point in the history

  3. Replace chevron button with hamburder

    @taneliang
    taneliang committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    b4261ec View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    44e6104 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    c1f8d13 View commit details
    Browse the repository at this point in the history

  3. Make all nav buttons color: var(--gray-mid)

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f773176 View commit details
    Browse the repository at this point in the history

  4. Make GlobalSearch always opened 

    Single commit so that this can hopefully be reverted easily if we prefer
collapsing.
    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    328bd15 View commit details
    Browse the repository at this point in the history

  5. Use Downshift's isOpen in GlobalSearch

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    9d8d1d9 View commit details
    Browse the repository at this point in the history

  6. Give up on avoiding Navbar shadow appearing over SearchkitSearchBox

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    dcd9bba View commit details
    Browse the repository at this point in the history

  7. Remove $navtabs-z-index

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    f739d05 View commit details
    Browse the repository at this point in the history

  8. Clean up code

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    15a636e View commit details
    Browse the repository at this point in the history

  9. stylelint --fix

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    fbb13e7 View commit details
    Browse the repository at this point in the history

  10. Update Navtabs -> Navbar tests

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    9ca80d7 View commit details
    Browse the repository at this point in the history

  11. Add AY/sem/week text to dropdown

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    c7f3034 View commit details
    Browse the repository at this point in the history

  12. Add AY calendar links to dropdown

    @taneliang
    taneliang committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    9c889b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    fdd8a8c View commit details
    Browse the repository at this point in the history

  2. Misc NavDropdown fixes

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    8605446 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    60e3c3c View commit details
    Browse the repository at this point in the history

  4. Redesign global dropdown using NavDropdown styles

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    2ba7c51 View commit details
    Browse the repository at this point in the history

  5. Fix DropdownListFilters funky checkboxes with new dropdown-items

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    f44ad5a View commit details
    Browse the repository at this point in the history

  6. Move dropdown-item with icons styles into global styles

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    2004359 View commit details
    Browse the repository at this point in the history

  7. Redesign GlobalSearch

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    c9248e7 View commit details
    Browse the repository at this point in the history

  8. Fix AddModuleDropdown spacing

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    cdf171d View commit details
    Browse the repository at this point in the history

  9. Move SemesterBadge margin to its left side

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    101bfc1 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary styles

    @taneliang
    taneliang committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    ed28932 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Delete unused AppShell.scss

    @taneliang
    taneliang committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    ea3eaba View commit details
    Browse the repository at this point in the history

  2. Remove width:100% from global dropdown-menu to fix ExportMenu truncation

    @taneliang
    taneliang committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    4536c3c View commit details
    Browse the repository at this point in the history

  3. GlobalSearch: allow focus to open dropdown

    @taneliang
    taneliang committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    8cc64c8 View commit details
    Browse the repository at this point in the history

  4. GlobalSearch: Add aria-label to view all buttons

    @taneliang
    taneliang committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    066ef8d View commit details
    Browse the repository at this point in the history

  5. Update Navbar test snapshots

    @taneliang
    taneliang committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    3f3d9ae View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into eliang/new-nav

    @taneliang
    taneliang committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    27ec54c View commit details
    Browse the repository at this point in the history