Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node-sass with Dart Sass #3197

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Replace node-sass with Dart Sass #3197

merged 1 commit into from
Jan 26, 2021

Conversation

taneliang
Copy link
Member

@taneliang taneliang commented Jan 26, 2021

LibSass has been deprecated. Their maintainers recommend switching to Dart Sass instead.

Test plan: ran yarn start and yarn build; no apparent changes.

LibSass has been deprecated. Their maintainers
[recommend](https://sass-lang.com/blog/libsass-is-deprecated) switching
to Dart Sass instead.

Test plan: ran `yarn start` and `yarn build`; no visual changes.
@taneliang taneliang requested a review from a team January 26, 2021 10:27
@vercel
Copy link

vercel bot commented Jan 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/fylg2kfrn
✅ Preview: https://nusmods-website-git-eliang-rip-node-sass.nusmodifications.vercel.app

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/quzpracd6
✅ Preview: https://nusmods-export-git-eliang-rip-node-sass.nusmodifications.vercel.app

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #3197 (ad15c0b) into master (9dd0a85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3197   +/-   ##
=======================================
  Coverage   55.44%   55.44%           
=======================================
  Files         254      254           
  Lines        5317     5317           
  Branches     1227     1227           
=======================================
  Hits         2948     2948           
  Misses       2369     2369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd0a85...ad15c0b. Read the comment docs.

@nusmods-deploy-bot
Copy link

@taneliang
Copy link
Member Author

Merging without approval to unblock #3155

@taneliang taneliang merged commit d473f78 into master Jan 26, 2021
@taneliang taneliang deleted the eliang/rip-node-sass branch January 26, 2021 10:43
@ZhangYiJiang
Copy link
Member

Is there a diff in the CSS output? I think that's the easiest way to check for regressions

@taneliang
Copy link
Member Author

I did try to diff the generated CSS, but it was minified so it wasn't useful 😆 Anyway I figured it was unlikely that anything would break so I didn't pursue it further. This is what I did:

# Remove `contenthash` from `filename` and `chunkFilename` in `MiniCssExtractPlugin` config object in webpack.parts.js.

git checkout master
yarn && yarn build

mv dist dist-nodesass

git checkout eliang/rip-node-sass
yarn && yarn build

diff dist dist-nodesass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants