Allows searching for multiple scales to be configurable #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zephraph, thanks for your contribution! Like you already mentioned, tests verifying your change would be great 👍 You already updated the docstring, so API docs are fine. |
s1hofmann
requested changes
Nov 7, 2020
|
@zephraph Any update on this PR? |
|
No updates yet, sorry! Let me follow up tonight. |
|
@s1hofmann let me know if that's enough |
|
Hi @zephraph 👋 Looks good to me, LGTM! Once again, thanks for your contribution! |
s1hofmann
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In running a small program that was searching for a label in a small, constrained region I was a bit surprised that it could take 5 seconds to find a match. My first thought was io (hence the other pr). Turns out, the multiple scale search is the vast majority of the time. In usecases where the relative size of the needle will be fixed, being able to disable this greatly increases the speed of the search (taking it down to a second or less).
I haven't added tests yet and I'm sure there's extra doc updating that needs to happen. Wanted to run this by you first to see if it's on track.