Skip to content

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Sep 9, 2025

What problem does this PR solve?:
Uses kustomize to generate the failuredomain example files and skip kube-proxy installation.

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR uses kustomize to generate failuredomain example files for Nutanix clusters, which automates the creation of cluster configurations with failure domain support. The changes also include skipping kube-proxy installation when using Cilium CNI.

  • Adds kustomize generation for Nutanix failure domain examples in the sync script
  • Creates dedicated kustomization templates and patches for failure domain configurations
  • Generates example YAML files for both helm-addon and CRS strategies with Cilium CNI

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
hack/examples/sync.sh Adds loop to generate Nutanix failure domain examples using kustomize
hack/examples/patches/nutanix/use-failure-domains.yaml Defines JSON patches to configure failure domains and add worker machine deployment
hack/examples/overlays/clusters/nutanix-with-failuredomain/cilium/helm-addon/kustomization.yaml.tmpl Kustomization template for helm-addon strategy with failure domains
hack/examples/overlays/clusters/nutanix-with-failuredomain/cilium/crs/kustomization.yaml.tmpl Kustomization template for CRS strategy with failure domains
hack/examples/additional-resources/nutanix/failure-domains.yaml Defines three NutanixFailureDomain resources for cluster configuration
examples/capi-quick-start/nutanix-cluster-failuredomain-cilium-helm-addon.yaml Generated example cluster with failure domains and helm-addon strategy
examples/capi-quick-start/nutanix-cluster-failuredomain-cilium-crs.yaml Generated example cluster with failure domains and CRS strategy

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dkoshkin dkoshkin force-pushed the dkoshkin/build-failuredomain-examples-with-kustomize branch from 41e031c to a4d29a1 Compare September 9, 2025 22:48
@dkoshkin dkoshkin force-pushed the dkoshkin/build-failuredomain-examples-with-kustomize branch from 00a76fd to ea3c997 Compare September 9, 2025 23:01
@dkoshkin dkoshkin enabled auto-merge (squash) September 11, 2025 15:32
Copy link
Contributor

@yanhua121 yanhua121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use of the generated example yaml files for cilium? I see there are already example yaml files at https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/releases/tag/v0.33.1. nutanix-cluster-failuredomain-cilium-crs.yaml and nutanix-cluster-failuredomain-cilium-helm-addon.yaml
Generates example YAML files for both helm-addon and CRS strategies with Cilium CNI

@yanhua121
Copy link
Contributor

What's the use of the generated example yaml files for cilium? I see there are already example yaml files at https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/releases/tag/v0.33.1. nutanix-cluster-failuredomain-cilium-crs.yaml and nutanix-cluster-failuredomain-cilium-helm-addon.yaml Generates example YAML files for both helm-addon and CRS strategies with Cilium CNI

Clarified.

@dkoshkin dkoshkin merged commit 6f519eb into main Sep 11, 2025
22 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/build-failuredomain-examples-with-kustomize branch September 11, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants