-
Notifications
You must be signed in to change notification settings - Fork 8
build: use kustomize to generate failuredomain examples #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use kustomize to generate failuredomain examples #1294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR uses kustomize to generate failuredomain example files for Nutanix clusters, which automates the creation of cluster configurations with failure domain support. The changes also include skipping kube-proxy installation when using Cilium CNI.
- Adds kustomize generation for Nutanix failure domain examples in the sync script
- Creates dedicated kustomization templates and patches for failure domain configurations
- Generates example YAML files for both helm-addon and CRS strategies with Cilium CNI
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
hack/examples/sync.sh | Adds loop to generate Nutanix failure domain examples using kustomize |
hack/examples/patches/nutanix/use-failure-domains.yaml | Defines JSON patches to configure failure domains and add worker machine deployment |
hack/examples/overlays/clusters/nutanix-with-failuredomain/cilium/helm-addon/kustomization.yaml.tmpl | Kustomization template for helm-addon strategy with failure domains |
hack/examples/overlays/clusters/nutanix-with-failuredomain/cilium/crs/kustomization.yaml.tmpl | Kustomization template for CRS strategy with failure domains |
hack/examples/additional-resources/nutanix/failure-domains.yaml | Defines three NutanixFailureDomain resources for cluster configuration |
examples/capi-quick-start/nutanix-cluster-failuredomain-cilium-helm-addon.yaml | Generated example cluster with failure domains and helm-addon strategy |
examples/capi-quick-start/nutanix-cluster-failuredomain-cilium-crs.yaml | Generated example cluster with failure domains and CRS strategy |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
examples/capi-quick-start/nutanix-cluster-failuredomain-cilium-helm-addon.yaml
Show resolved
Hide resolved
41e031c
to
a4d29a1
Compare
00a76fd
to
ea3c997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use of the generated example yaml files for cilium? I see there are already example yaml files at https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/releases/tag/v0.33.1. nutanix-cluster-failuredomain-cilium-crs.yaml and nutanix-cluster-failuredomain-cilium-helm-addon.yaml
Generates example YAML files for both helm-addon and CRS strategies with Cilium CNI
Clarified. |
What problem does this PR solve?:
Uses kustomize to generate the failuredomain example files and skip kube-proxy installation.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: