Skip to content

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Sep 12, 2025

What problem does this PR solve?:
Stacked on #1297

This fixes the generic handlers for EKS clusters by properly exposing the GenericClusterConfigSpec API in EKSClusterConfig.

The following fields are still aspirational and are not properly supported in the handlers for EKS, but they can be.

	// +kubebuilder:validation:Optional
	Proxy *HTTPProxy `json:"proxy,omitempty"`

	// +kubebuilder:validation:Optional
	// +kubebuilder:validation:MaxItems=32
	ImageRegistries []ImageRegistry `json:"imageRegistries,omitempty"`

	// +kubebuilder:validation:Optional
	GlobalImageRegistryMirror *GlobalImageRegistryMirror `json:"globalImageRegistryMirror,omitempty"`

But these are working and I've added broken tests to verify before fixing the API.

	// +kubebuilder:validation:Optional
	// +kubebuilder:validation:MaxItems=32
	Users []User `json:"users,omitempty"`

	// NTP defines the NTP configuration for the cluster.
	// +kubebuilder:validation:Optional
	NTP *NTP `json:"ntp,omitempty"`

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

@github-actions github-actions bot added fix and removed fix labels Sep 12, 2025
@dkoshkin dkoshkin force-pushed the dkoshkin/fix-EKS-api branch from f56bb00 to 7318f37 Compare September 13, 2025 00:30
@dkoshkin dkoshkin changed the title fix: include GenericClusterConfigSpec in EKS cluster API fix: include Generic config specs in EKS cluster API Sep 13, 2025
@github-actions github-actions bot added fix and removed fix labels Sep 13, 2025
@dkoshkin dkoshkin force-pushed the dkoshkin/fix-EKS-api branch from 7318f37 to 3e49daf Compare September 13, 2025 00:38
@github-actions github-actions bot removed the stacked label Sep 15, 2025
@dkoshkin dkoshkin requested a review from yanhua121 September 15, 2025 17:04
Base automatically changed from dkoshkin/refactor-GenericClusterConfigSpec to main September 16, 2025 17:40
@github-actions github-actions bot added fix and removed fix labels Sep 16, 2025
@dkoshkin dkoshkin enabled auto-merge (squash) September 16, 2025 17:50
@dkoshkin dkoshkin merged commit b70ffab into main Sep 16, 2025
22 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/fix-EKS-api branch September 16, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants