issue#481 fix invalid dn check for OU vs group or user #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groups don't start with ou= but may be within an OU so would contain ou= in the string. This change makes it so groups don't have to be in the root of the AD.
change config check to start with ou= for OU
stahnjones
changed the title
…k_in_protection_rules Imprv nutanix#488 Update ntnx_protection_rules.py with start_time comparison in idempotency check
|
Seems that maybe I didn't do the previous PR correctly and it combined the two here |
bhati-pradeep
requested changes
Jul 25, 2024
|
Thank you for raising PR |
|
@abhinavbansal29 can you please review this PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix invalid dn check for OU vs group or user