Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2873: Handle workflow in drive #4912

Merged
merged 15 commits into from
Jul 25, 2024

Conversation

swetayadav1
Copy link
Contributor

@swetayadav1 swetayadav1 commented May 23, 2024

NXDRIVE-2873: Handle workflow in drive

swetayadav1 and others added 2 commits May 20, 2024 11:59
* NXDRIVE-2889: Display system notification for document review

* NXDRIVE-2899: Display new workflow feature on features tab (#4793)
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

nxdrive/client/workflow/__init__.py Outdated Show resolved Hide resolved
nxdrive/client/workflow/__init__.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 82.24543% with 68 lines in your changes missing coverage. Please review.

Project coverage is 52.19%. Comparing base (74fc14e) to head (4861edd).
Report is 14 commits behind head on master.

Files Patch % Lines
nxdrive/gui/application.py 17.33% 62 Missing ⚠️
nxdrive/client/workflow/__init__.py 92.45% 4 Missing ⚠️
nxdrive/manager.py 92.85% 1 Missing ⚠️
nxdrive/utils.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4912      +/-   ##
==========================================
+ Coverage   49.24%   52.19%   +2.94%     
==========================================
  Files          94       95       +1     
  Lines       15699    16054     +355     
==========================================
+ Hits         7731     8379     +648     
+ Misses       7968     7675     -293     
Flag Coverage Δ
functional 42.92% <61.87%> (+4.84%) ⬆️
integration 2.01% <0.00%> (-0.05%) ⬇️
unit 40.58% <49.08%> (+3.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

swetayadav1 and others added 11 commits June 4, 2024 18:25
#5001)

* NXDRIVE-2889: Display system notification for document review(fix)
* NXDRIVE-2912: Display Drive notification for document review

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: mr-shekhar <85621953+mr-shekhar@users.noreply.github.com>
Co-authored-by: swetayadav1 <sweta.yadav@hyland.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: poojadaine <126543069+poojadaine@users.noreply.github.com>
Co-authored-by: Sweta Yadav <106366788+swetayadav1@users.noreply.github.com>
Co-authored-by: swetayadav1 <sweta.yadav@hyalnd.com>
Co-authored-by: GitHub-CI action (Release) <drive@hyland.com>
Co-authored-by: Pooja Ramkrishna Daine <Pooja.RamkrishnaDaine@hyland.com>
Co-authored-by: Filip <filip.weyer@hyland.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Sushil Chaudhary <sushil.chaudhary2@globallogic.com>
Co-authored-by: sushildeep <sushildeep@hotmail.com>
…ize notifications) (#5053)

* NXDRIVE-2889: Display system notification for document review(Categorize Notifications)
… code (#5064)

* NXDRIVE-2948: Add translations to hardcoded strings and refractor the code
@gitofanindya gitofanindya merged commit b0e51bd into master Jul 25, 2024
22 checks passed
@gitofanindya gitofanindya deleted the wip-NXDRIVE-2873-Handle-workflow-in-drive branch July 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants