feat(workbox): offlineStrategy

BREAKING CHANGE: default changed from NetworkOnly to NetworkFirst when offlinePage is enabled
nuxt-community · May 7, 2019 · e377436 · e377436
1 parent 4fef661
commit e377436
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 4 deletions.
diff --git a/packages/workbox/lib/defaults.js b/packages/workbox/lib/defaults.js
@@ -25,6 +25,7 @@ module.exports = {
 
   // Offline
   offline: true,
+  offlineStrategy: 'NetworkFirst',
   offlinePage: null,
   offlineAssets: [],
 

diff --git a/packages/workbox/lib/options.js b/packages/workbox/lib/options.js
@@ -56,7 +56,7 @@ function getOptions (moduleOptions) {
   if (options.offline && !options.offlinePage) {
     options.runtimeCaching.push({
       urlPattern: options.pagesURLPattern,
-      handler: 'NetworkFirst'
+      handler: options.offlineStrategy
     })
   }
 

diff --git a/packages/workbox/templates/sw.js b/packages/workbox/templates/sw.js
@@ -63,7 +63,7 @@ workbox.precaching.precacheAndRoute(<%= JSON.stringify(options.preCaching, null,
 <% if (options.offlinePage) { %>
 // Register router handler for offlinePage
 workbox.routing.registerRoute(new RegExp('<%= options.pagesURLPattern %>'), ({event}) => {
-  return new workbox.strategies.NetworkOnly().handle({event})
+  return new workbox.strategies.<%= options.offlineStrategy %>().handle({event})
     .catch(() => caches.match('<%= options.offlinePage %>'))
 })<% } %>
 

diff --git a/test/__snapshots__/pwa.test.js.snap b/test/__snapshots__/pwa.test.js.snap
@@ -110,7 +110,7 @@ workbox.routing.registerRoute(new RegExp('/_nuxt/(?!.*(__webpack_hmr|hot-update)
 
 // Register router handler for offlinePage
 workbox.routing.registerRoute(new RegExp('/(?!.*(__webpack_hmr|hot-update))'), ({event}) => {
-  return new workbox.strategies.NetworkOnly().handle({event})
+  return new workbox.strategies.NetworkFirst().handle({event})
     .catch(() => caches.match('/offline.html'))
 })
 

diff --git a/test/fixture/layouts/default.vue b/test/fixture/layouts/default.vue
@@ -5,7 +5,7 @@
     <nuxt-link
       v-for="p in ['Foo', 'Bar', 'Baz']"
       :key="p"
-      :to="'/' + p"
+      :to="'/' + p.toLowerCase()"
     >
       {{ p }}
     </nuxt-link>

diff --git a/test/fixture/pages/_page.vue b/test/fixture/pages/_page.vue
@@ -0,0 +1,5 @@
+<template>
+<main>
+  You are on page: {{ $route.path }}
+</main>
+</template>